Messages in this thread | | | Date | Thu, 17 Sep 2020 13:41:58 +0530 | From | Bhaskar Chowdhury <> | Subject | Re: [PATCH v3] docs: fb: Remove framebuffer scrollback boot option |
| |
On 09:47 Thu 17 Sep 2020, Greg KH wrote: >On Thu, Sep 17, 2020 at 04:31:50AM +0530, Bhaskar Chowdhury wrote: >> This patch remove reference to this option in this document and >> renumbered the sections. This is related to below commits. >> >> Commit 973c096f6a85(vgacon: remove software scrollback support) >> Commit 50145474f6ef(fbcon: remove soft scrollback code) >> >> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> >> --- >> This version try to correct the previous errors, proper changelog text, subject >> Trying to incorporate Willy's & Greg's suggestions > >Better, but... > >This should be a patch series, properly numbered and threaded, right? > >The text above still has the commit ids not properly referenced, and you >have trailing whitespace in the text too. > I will certainly fix that in the upcoming version.
>Writing the changelog is often times the hardest part of a patch, as you >are finding out. > Yes..true. >How about this example, for this specific patch, as a changelog text: > >--------- >In commit 50145474f6ef ("fbcon: remove soft scrollback code"), the >framebuffer scrollback mode was removed, but the documentation was not >updated. Properly update the documentation by removing the option that >is no longer present, and update the section numbering because of the >removal. >--------- Just like an pointed arrow ..perfect...cut to the cheese! > >Doesn't that make more sense about what is happening here, and provide >enough information that when someone 10+ years from now goes and tries >to find out why a boot option went away, what exactly happened and why? > Absolutely.
>Can you make this type of change to all 4 of these patches and resend >them, with the proper change information below the --- line as a v4 >series? >
Certain thing...will incorporate your suggestions in V4 and send.
>thanks,
Indebted for your and others patience for standing this long ..thank you! > >greg k-h [unhandled content-type:application/pgp-signature] | |