lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 05/90] ata: sata_mv, avoid trigerrable BUG_ON
    Date
    From: Jiri Slaby <jslaby@suse.cz>

    [ Upstream commit e9f691d899188679746eeb96e6cb520459eda9b4 ]

    There are several reports that the BUG_ON on unsupported command in
    mv_qc_prep can be triggered under some circumstances:
    https://bugzilla.suse.com/show_bug.cgi?id=1110252
    https://serverfault.com/questions/888897/raid-problems-after-power-outage
    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1652185
    https://bugs.centos.org/view.php?id=14998

    Let sata_mv handle the failure gracefully: warn about that incl. the
    failed command number and return an AC_ERR_INVALID error. We can do that
    now thanks to the previous patch.

    Remove also the long-standing FIXME.

    [v2] use %.2x as commands are defined as hexa.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: linux-ide@vger.kernel.org
    Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ata/sata_mv.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
    index 2f32782cea6d9..2ec37a038eda8 100644
    --- a/drivers/ata/sata_mv.c
    +++ b/drivers/ata/sata_mv.c
    @@ -2111,12 +2111,10 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
    * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none
    * of which are defined/used by Linux. If we get here, this
    * driver needs work.
    - *
    - * FIXME: modify libata to give qc_prep a return value and
    - * return error here.
    */
    - BUG_ON(tf->command);
    - break;
    + ata_port_err(ap, "%s: unsupported command: %.2x\n", __func__,
    + tf->command);
    + return AC_ERR_INVALID;
    }
    mv_crqb_pack_cmd(cw++, tf->nsect, ATA_REG_NSECT, 0);
    mv_crqb_pack_cmd(cw++, tf->hob_lbal, ATA_REG_LBAL, 0);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:30    [W:3.536 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site