lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 039/206] ASoC: max98090: remove msleep in PLL unlocked workaround
    Date
    From: Tzung-Bi Shih <tzungbi@google.com>

    [ Upstream commit acb874a7c049ec49d8fc66c893170fb42c01bdf7 ]

    It was observed Baytrail-based chromebooks could cause continuous PLL
    unlocked when using playback stream and capture stream simultaneously.
    Specifically, starting a capture stream after started a playback stream.
    As a result, the audio data could corrupt or turn completely silent.

    As the datasheet suggested, the maximum PLL lock time should be 7 msec.
    The workaround resets the codec softly by toggling SHDN off and on if
    PLL failed to lock for 10 msec. Notably, there is no suggested hold
    time for SHDN off.

    On Baytrail-based chromebooks, it would easily happen continuous PLL
    unlocked if there is a 10 msec delay between SHDN off and on. Removes
    the msleep().

    Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
    Link: https://lore.kernel.org/r/20191122073114.219945-2-tzungbi@google.com
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/max98090.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
    index 89b6e187ac235..a5b0c40ee545f 100644
    --- a/sound/soc/codecs/max98090.c
    +++ b/sound/soc/codecs/max98090.c
    @@ -2130,10 +2130,16 @@ static void max98090_pll_work(struct max98090_priv *max98090)

    dev_info_ratelimited(component->dev, "PLL unlocked\n");

    + /*
    + * As the datasheet suggested, the maximum PLL lock time should be
    + * 7 msec. The workaround resets the codec softly by toggling SHDN
    + * off and on if PLL failed to lock for 10 msec. Notably, there is
    + * no suggested hold time for SHDN off.
    + */
    +
    /* Toggle shutdown OFF then ON */
    snd_soc_component_update_bits(component, M98090_REG_DEVICE_SHUTDOWN,
    M98090_SHDNN_MASK, 0);
    - msleep(10);
    snd_soc_component_update_bits(component, M98090_REG_DEVICE_SHUTDOWN,
    M98090_SHDNN_MASK, M98090_SHDNN_MASK);

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:09    [W:4.101 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site