lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 104/330] tracing: Set kernel_stack's caller size properly
    Date
    From: Josef Bacik <jbacik@fb.com>

    [ Upstream commit cbc3b92ce037f5e7536f6db157d185cd8b8f615c ]

    I noticed when trying to use the trace-cmd python interface that reading the raw
    buffer wasn't working for kernel_stack events. This is because it uses a
    stubbed version of __dynamic_array that doesn't do the __data_loc trick and
    encode the length of the array into the field. Instead it just shows up as a
    size of 0. So change this to __array and set the len to FTRACE_STACK_ENTRIES
    since this is what we actually do in practice and matches how user_stack_trace
    works.

    Link: http://lkml.kernel.org/r/1411589652-1318-1-git-send-email-jbacik@fb.com

    Signed-off-by: Josef Bacik <jbacik@fb.com>
    [ Pulled from the archeological digging of my INBOX ]
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/trace/trace_entries.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/trace/trace_entries.h b/kernel/trace/trace_entries.h
    index fc8e97328e540..78c146efb8623 100644
    --- a/kernel/trace/trace_entries.h
    +++ b/kernel/trace/trace_entries.h
    @@ -174,7 +174,7 @@ FTRACE_ENTRY(kernel_stack, stack_entry,

    F_STRUCT(
    __field( int, size )
    - __dynamic_array(unsigned long, caller )
    + __array( unsigned long, caller, FTRACE_STACK_ENTRIES )
    ),

    F_printk("\t=> %ps\n\t=> %ps\n\t=> %ps\n"
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-09-18 04:03    [W:3.604 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site