Messages in this thread | | | Date | Thu, 17 Sep 2020 18:16:04 +0100 | From | Al Viro <> | Subject | Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code |
| |
On Thu, Sep 17, 2020 at 10:22:33AM +0200, Christoph Hellwig wrote: > There is no reason the generic fs code should bother with NFS specific > binary mount data - lift the conversion into nfs4_parse_monolithic > instead.
Considering the size of struct compat_nfs4_mount_data_v1... Do we really need to bother with that "copy in place, so we go through the fields backwards" logics? Just make that
> +static void nfs4_compat_mount_data_conv(struct nfs4_mount_data *data) > +{ struct compat_nfs4_mount_data_v1 compat; compat = *(struct compat_nfs4_mount_data_v1 *)data; and copy the damnt thing without worrying about the field order...
| |