lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs
    Nitesh Narayan Lal wrote:

    > In a realtime environment, it is essential to isolate unwanted IRQs from
    > isolated CPUs to prevent latency overheads. Creating MSIX vectors only
    > based on the online CPUs could lead to a potential issue on an RT setup
    > that has several isolated CPUs but a very few housekeeping CPUs. This is
    > because in these kinds of setups an attempt to move the IRQs to the
    > limited housekeeping CPUs from isolated CPUs might fail due to the per
    > CPU vector limit. This could eventually result in latency spikes because
    > of the IRQ threads that we fail to move from isolated CPUs.
    >
    > This patch prevents i40e to add vectors only based on available
    > housekeeping CPUs by using num_housekeeping_cpus().
    >
    > Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>

    The driver changes are straightforward, but this isn't the only driver
    with this issue, right? I'm sure ixgbe and ice both have this problem
    too, you should fix them as well, at a minimum, and probably other
    vendors drivers:

    $ rg -c --stats num_online_cpus drivers/net/ethernet
    ...
    50 files contained matches

    for this patch i40e
    Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

    \
     
     \ /
      Last update: 2020-09-17 20:34    [W:4.077 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site