lkml.org 
[lkml]   [2020]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/5] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode
    Date
    In order to keep OTG ID detection even when in Host mode, the ID line of
    the PHY (if the current phy is an OTG one) pull-up should be kept
    enable in both modes.

    This fixes OTG switch on GXL, GXM & AXG platforms, otherwise once switched
    to Host, the ID detection doesn't work anymore to switch back to Device.

    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Reviewed-by: Kevin Hilman <khilman@baylibre.com>
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    ---
    drivers/phy/amlogic/phy-meson-gxl-usb2.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
    index 43ec9bf24abf..6e862ea60d8f 100644
    --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c
    +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
    @@ -158,7 +158,8 @@ static int phy_meson_gxl_usb2_set_mode(struct phy *phy,
    U2P_R0_DM_PULLDOWN);
    regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_DP_PULLDOWN,
    U2P_R0_DP_PULLDOWN);
    - regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_ID_PULLUP, 0);
    + regmap_update_bits(priv->regmap, U2P_R0, U2P_R0_ID_PULLUP,
    + U2P_R0_ID_PULLUP);
    break;

    case PHY_MODE_USB_DEVICE:
    --
    2.22.0
    \
     
     \ /
      Last update: 2020-09-17 09:08    [W:4.258 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site