Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 16 Sep 2020 20:26:56 +0300 | Subject | Re: [PATCH v2] platform/x86: Add Driver to set up lid GPEs on MS Surface device |
| |
On Wed, Sep 16, 2020 at 2:58 AM Barnabás Pőcze <pobrn@protonmail.com> wrote:
...
> > + dev_err(dev, "failed to set GPE wake mask: %d\n", status); > > I'm not sure if it's technically safe to print acpi_status with the %d format > specifier since 'acpi_status' is defined as 'u32' at the moment. > func("%lu", (unsigned long) status) > would be safer.
Please, no explicit castings for printf(). In 99% cases it means that something is not being used correctly.
-- With Best Regards, Andy Shevchenko
| |