Messages in this thread | | | Subject | Re: [PATCH] net: dsa: mt7530: Add some return-value checks | From | "Gustavo A. R. Silva" <> | Date | Wed, 16 Sep 2020 15:10:02 -0500 |
| |
On 9/16/20 14:50, Alex Dewar wrote:
[..]
> > drivers/net/dsa/mt7530.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >
[..]
> > /* Enable Mediatek header mode on the cpu port */ > mt7530_write(priv, MT7530_PVC_P(port), > @@ -2275,7 +2279,7 @@ mt7531_cpu_port_config(struct dsa_switch *ds, int port) > { > struct mt7530_priv *priv = ds->priv; > phy_interface_t interface; > - int speed; > + int ret, speed;
Don't do this. Instead, declare each variable on its own line. In this case, speed before ret.
Thanks -- Gustavo
| |