Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 16 Sep 2020 16:47:24 +0200 | Subject | Re: [PATCH next] gpiolib: check for parent device in devprop_gpiochip_set_names() |
| |
On Wed, Sep 16, 2020 at 4:29 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Wed, Sep 16, 2020 at 03:43:27PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > It's possible for a GPIO chip to not have a parent device (whose > > properties we inspect for 'gpio-line-names'). In this case we should > > simply return from devprop_gpiochip_set_names(). Add an appropriate > > check for this use-case. > > Ah, nice! > Can we also add a small comment in the code, b/c w/o it I would stumble over > and eager to remove looks-as-unneeded check? > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sure, I'll make a v2 then.
Bart
| |