Messages in this thread | | | Date | Wed, 16 Sep 2020 09:24:38 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v12 05/10] PCI: brcmstb: Add bcm7278 PERST# support |
| |
On Fri, Sep 11, 2020 at 01:52:25PM -0400, Jim Quinlan wrote: > From: Jim Quinlan <jquinlan@broadcom.com> > > The PERST# bit was moved to a different register in 7278-type STB chips. > In addition, the polarity of the bit was also changed; for other chips > writing a 1 specified assert; for 7278-type chips, writing a 0 specifies > assert. Of course, PERST# is a PCIe asserted-low signal. > > While we are here, also change the bridge_sw_init_set() functions so like > the perst_set() functions they are chip specific and we no longer rely on > data wrt chip specific field mask and shift values. > > Signed-off-by: Jim Quinlan <jquinlan@broadcom.com> > Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/pci/controller/pcie-brcmstb.c | 97 +++++++++++++++++++-------- > 1 file changed, 69 insertions(+), 28 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
| |