Messages in this thread | | | From | Enric Balletbo Serra <> | Date | Wed, 16 Sep 2020 10:26:34 +0200 | Subject | Re: [PATCH 4/6] irqchip/mtk-cirq: Allow modular build |
| |
Missatge de Bjorn Andersson <bjorn.andersson@linaro.org> del dia dg., 13 de set. 2020 a les 1:26: > > On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > > > Switch the driver to a "hybrid probe" model which preserves the > > built-in behaviour while allowing the driver to be optionnally > > built as a module for development purposes. > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Signed-off-by: Marc Zyngier <maz@kernel.org>
I've tested this on mt8173 and mt8183, and this time, the patches didn't break booting on these platforms. For MediaTek, right now, only makes sense the driver to be built-in as other drivers that use it are not ready for deferring their probe. So,
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks Enric
> > --- > > drivers/irqchip/irq-mtk-cirq.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c > > index 69ba8ce3c178..43e880b63ed2 100644 > > --- a/drivers/irqchip/irq-mtk-cirq.c > > +++ b/drivers/irqchip/irq-mtk-cirq.c > > @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node, > > return ret; > > } > > > > -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init); > > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_cirq) > > +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init) > > +IRQCHIP_HYBRID_DRIVER_END(mtk_cirq) > > -- > > 2.28.0 > >
| |