Messages in this thread | | | Subject | Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver | From | Randy Dunlap <> | Date | Wed, 16 Sep 2020 14:52:34 -0700 |
| |
On 9/16/20 12:56 PM, Hemant Kumar wrote: > diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig > index 6a217ff..8aebe8b 100644 > --- a/drivers/bus/mhi/Kconfig > +++ b/drivers/bus/mhi/Kconfig > @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG > Enable debugfs support for use with the MHI transport. Allows > reading and/or modifying some values within the MHI controller > for debug and test purposes.
Hi, Please indent Kconfig keywords with one tab only, and indent help text with one tab + 2 spaces, as documented in Documentation/process/coding-style.rst:
""" For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. """
> + > +config MHI_UCI > + tristate "MHI UCI" > + depends on MHI_BUS > + help > + MHI based userspace client interface driver is used for transferring > + raw data between host and device using standard file operations from > + userspace. Open, read, write, and close operations are supported > + by this driver. Please check mhi_uci_match_table for all supported > + channels that are exposed to userspace. > + > + To compile this driver as a module, choose M here: the module will be > + called mhi_uci.
thanks. -- ~Randy
| |