lkml.org 
[lkml]   [2020]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regmap: debugfs: Duplicate name string if delaying debugfs init
    On Wed, Sep 16, 2020 at 05:14:18PM +0100, Mark Brown wrote:
    > On Wed, Sep 16, 2020 at 04:44:33PM +0100, Charles Keepax wrote:
    >
    > > - node->name = name;
    > > + node->name = kstrdup(name, GFP_KERNEL);
    > > + if (!node->name) {
    >
    > Two things here - one is that this should be kstrdup_const(), the other
    > is that we already took a copy of the name in __regmap_init() so the
    > thing to do here is to change the regmap_debugfs_init() call there to
    > use the copy we just made rather than the copy in the config.

    Thanks Mark, I will have a look and update.

    Thanks,
    Charles

    \
     
     \ /
      Last update: 2020-09-16 22:40    [W:2.661 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site