lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: vidtv: fix build on 32bit architectures
From
Date
On 9/15/20 11:05 AM, Daniel W. S. Almeida wrote:
> From: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
>
> Fix the following error for builds on 32bit architectures:
>
> ERROR: modpost: "__udivdi3"
> [drivers/media/test-drivers/vidtv/dvb-vidtv-bridge.ko] undefined!
>
> Which is due to 64bit divisions that did not go through the helpers
> in linux/math64.h
>
> As vidtv_mux_check_mux_rate was not operational in its current form,
> drop the entire function while it is not fixed properly.
>
> For now, call vidtv_mux_pad_with_nulls with a constant number of packets
> to avoid warnings due to unused functions when building this driver.
>
> Fixes: f90cf6079bf67988 ("media: vidtv: add a bridge driver")
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
> drivers/media/test-drivers/vidtv/vidtv_mux.c | 34 +------------------
> .../media/test-drivers/vidtv/vidtv_s302m.c | 4 +--
> 2 files changed, 3 insertions(+), 35 deletions(-)
>

Works for me. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


--
~Randy

\
 
 \ /
  Last update: 2020-09-15 21:27    [W:0.098 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site