| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.8 051/177] spi: stm32: fix pm_runtime_get_sync() error checking | Date | Tue, 15 Sep 2020 16:12:02 +0200 |
| |
From: Dan Carpenter <dan.carpenter@oracle.com>
[ Upstream commit c170a5a3b6944ad8e76547c4a1d9fe81c8f23ac8 ]
The pm_runtime_get_sync() can return either 0 or 1 on success but this code treats 1 as a failure.
Fixes: db96bf976a4f ("spi: stm32: fixes suspend/resume management") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Alain Volmat <alain.volmat@st.com> Link: https://lore.kernel.org/r/20200909094304.GA420136@mwanda Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index a00f6b51ccbfc..3056428b09f31 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -2064,7 +2064,7 @@ static int stm32_spi_resume(struct device *dev) } ret = pm_runtime_get_sync(dev); - if (ret) { + if (ret < 0) { dev_err(dev, "Unable to power device:%d\n", ret); return ret; } -- 2.25.1
|