Messages in this thread | | | Subject | Re: [PATCH 3/3] staging: rtl8723bs: os_dep: fixed spacing around operators issue | From | Joe Perches <> | Date | Mon, 14 Sep 2020 19:30:02 -0700 |
| |
On Mon, 2020-09-14 at 19:17 -0500, Ross Schmidt wrote: > Fixed a coding style issue by adding spaces around operators in > sdio_ops_linux.c to fix checkpatch checks.
Hello Ross.
If you want to do more than fix whitespace, please look at the #define for DBG_871X.
All the uses with a KERN_<LEVEL> are broken and should be modified as _dbgdump is just printk and DRIVER_PREFIX is "RTL8723BS: " so the KERN_<LEVEL> after the DRIVER_PREFIX.
That's just broken.
#define DBG_871X(...) do {\ _dbgdump(DRIVER_PREFIX __VA_ARGS__);\ } while (0)
Realistically, the DBG_871X macro family should just use pr_debug and all the KERN_<LEVEL> uses should be removed.
The define and uses of RT_TRACE should also just be converted to use pr_debug or some other function to perhaps reduce overall object size
| |