Messages in this thread | | | Date | Fri, 11 Sep 2020 07:57:15 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h> |
| |
On Thu, 10 Sep 2020 23:07:20 -0700 Xie He wrote: > This header file is not actually used in this file. Let's remove it. > > Information about this header file: > > This header file comes from the "Frame Relay" module at > drivers/net/wan/dlci.c > > The "Frame Relay" module is used by only one hardware driver, at: > drivers/net/wan/sdla.c > > Note that the "Frame Relay" module is different from and unrelated to the > "HDLC Frame Relay" module at: > drivers/net/wan/hdlc_fr.c > > I think maybe we can deprecate the "Frame Relay" module because we already > have the (newer) "HDLC Frame Relay" module. > > Signed-off-by: Xie He <xie.he.0141@gmail.com>
net/socket.c:1032:6: warning: no previous prototype for ‘dlci_ioctl_set’ [-Wmissing-prototypes] 1032 | void dlci_ioctl_set(int (*hook) (unsigned int, void __user *)) | ^~~~~~~~~~~~~~ net/socket.c:1032:6: warning: symbol 'dlci_ioctl_set' was not declared. Should it be static?
| |