lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 4/9] iomap: Use bitmap ops to set uptodate bits
    Date
    Now that the bitmap is protected by a spinlock, we can use the
    more efficient bitmap ops instead of individual test/set bit ops.

    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    ---
    fs/iomap/buffered-io.c | 12 ++----------
    1 file changed, 2 insertions(+), 10 deletions(-)

    diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
    index 58a1fd83f2a4..7fc0e02d27b0 100644
    --- a/fs/iomap/buffered-io.c
    +++ b/fs/iomap/buffered-io.c
    @@ -134,19 +134,11 @@ iomap_iop_set_range_uptodate(struct page *page, unsigned off, unsigned len)
    struct inode *inode = page->mapping->host;
    unsigned first = off >> inode->i_blkbits;
    unsigned last = (off + len - 1) >> inode->i_blkbits;
    - bool uptodate = true;
    unsigned long flags;
    - unsigned int i;

    spin_lock_irqsave(&iop->uptodate_lock, flags);
    - for (i = 0; i < i_blocks_per_page(inode, page); i++) {
    - if (i >= first && i <= last)
    - set_bit(i, iop->uptodate);
    - else if (!test_bit(i, iop->uptodate))
    - uptodate = false;
    - }
    -
    - if (uptodate)
    + bitmap_set(iop->uptodate, first, last - first + 1);
    + if (bitmap_full(iop->uptodate, i_blocks_per_page(inode, page)))
    SetPageUptodate(page);
    spin_unlock_irqrestore(&iop->uptodate_lock, flags);
    }
    --
    2.28.0
    \
     
     \ /
      Last update: 2020-09-11 01:49    [W:4.117 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site