lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] i2c: stm32: do not display error when DMA is not requested
On Thu, 10 Sep 2020 at 14:27, Alain Volmat <alain.volmat@st.com> wrote:
>
> On Thu, Sep 10, 2020 at 12:06:07PM +0200, Wolfram Sang wrote:
> > On Thu, Sep 10, 2020 at 11:32:29AM +0200, Alain Volmat wrote:
> > > DMA usage is optional for the I2C driver. check for the -ENODEV
> > > error in order to avoid displaying an error when no DMA
> > > has been requested.
> > >
> > > Signed-off-by: Alain Volmat <alain.volmat@st.com>
> > > ---
> > > This patch should be applied on top of the patch [i2c: stm32: Simplify with dev_err_probe()]
> >
> > We can do it in this order, it just makes backporting to stable kernels
> > (if that is desired) a bit harder than a self-contained patch. I am fine
> > with both approaches, but just wanted to point it out.
>
> Indeed, that's a good point. I'll rework it then, to avoid the dependency
> on dev_err_probe change. If that is ok, I propose to push a two patches serie
> with both this fix (updated) followed by a rebased version of the
> dev_err_probe patch from Krzysztof for dev_err_probe change.

I can rebase mine on top of yours. Indeed such cleanups as mine should
be rather later in the queue.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-09-10 23:37    [W:0.038 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site