Messages in this thread | | | Subject | Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug() | From | Harry Wentland <> | Date | Thu, 10 Sep 2020 11:34:34 -0400 |
| |
On 2020-09-09 11:26 p.m., YueHaibing wrote: > If parse_write_buffer_into_params() fails, we should free > wr_buf before return. > > Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > index 83da24aced45..11e16fbe484d 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c > @@ -1089,8 +1089,10 @@ static ssize_t dp_trigger_hotplug(struct file *f, const char __user *buf, > if (parse_write_buffer_into_params(wr_buf, wr_buf_size, > (long *)param, buf, > max_param_num, > - ¶m_nums)) > + ¶m_nums)) { > + kfree(wr_buf); > return -EINVAL; > + } > > if (param_nums <= 0) { > DRM_DEBUG_DRIVER("user data not be read\n"); >
| |