Messages in this thread | | | From | Joel Stanley <> | Date | Tue, 1 Sep 2020 06:00:24 +0000 | Subject | Re: [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device |
| |
On Thu, 20 Aug 2020 at 16:12, Eddie James <eajames@linux.ibm.com> wrote: > > Set I2C bus 0 to multi-master mode and add the panel device that will > register as a slave. > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> --- > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > index 5f4ee67ac787..9cf2e02ae9e2 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > @@ -438,7 +438,13 @@ aliases { > }; > > &i2c0 { > + multi-master; > status = "okay"; > + > + ibm-panel@62 { > + compatible = "ibm,op-panel"; > + reg = <0x40000062>; /* I2C_OWN_SLAVE_ADDRESS */
Other users of SLAVE_ADDRESS have included <dt-bindings/i2c/i2c.h> and written the reg as follows:
reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)>
Which obviously has the same result. I'll leave it up to you.
Cheers,
Joel
> + }; > }; > > &i2c1 { > -- > 2.26.2 >
| |