Messages in this thread | | | Date | Tue, 1 Sep 2020 14:09:56 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH v6 31/76] x86/head/64: Setup MSR_GS_BASE before calling into C code |
| |
On Fri, Aug 28, 2020 at 08:13:46PM +0200, Borislav Petkov wrote: > On Mon, Aug 24, 2020 at 10:54:26AM +0200, Joerg Roedel wrote: > > + movl $MSR_GS_BASE,%ecx > > I'm confused: is this missing those three lines: > > movl initial_gs(%rip),%eax > movl initial_gs+4(%rip),%edx > wrmsr > > as it is done in secondary_startup_64 ?
No, it is a leftover from before I moved the MSR write into startup_64_setup_env(). I removed it, thanks for catching this.
Regards,
Joerg
| |