Messages in this thread | | | Subject | Re: [PATCH] drivers: reduce the param length of the line | From | Heiner Kallweit <> | Date | Tue, 1 Sep 2020 09:29:43 +0200 |
| |
On 01.09.2020 04:28, Tong Chen wrote: > Reduce the param length of the line from 79 chars to 52 chars, > which complies with kernel preferences.
Apart from formal issues with the patch (missing net/net-next annotation, wrong prefix): Did you get a checkpatch warning? Or what's the source of your assumed kernel preference?
> Signed-off-by: Tong Chen <tongchen@whu.edu.cn> > --- > drivers/net/ethernet/realtek/r8169_phy_config.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c > index 913d030d73eb..f4b738cf8ad7 100644 > --- a/drivers/net/ethernet/realtek/r8169_phy_config.c > +++ b/drivers/net/ethernet/realtek/r8169_phy_config.c > @@ -1302,7 +1302,8 @@ static void rtl8125b_hw_phy_config(struct rtl8169_private *tp, > rtl8125b_config_eee_phy(phydev); > } > > -void r8169_hw_phy_config(struct rtl8169_private *tp, struct phy_device *phydev, > +void r8169_hw_phy_config(struct rtl8169_private *tp, > + struct phy_device *phydev, > enum mac_version ver) > { > static const rtl_phy_cfg_fct phy_configs[] = { >
| |