Messages in this thread | | | Date | Tue, 1 Sep 2020 18:39:05 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] signal: clean up codestyle |
| |
On 09/01, Christian Brauner wrote: > > On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote: > > No functional change intended. > > Hey Miaohe, > > Thank you for the patch. > I'm sure this is well-intended but afaict the whole file has more or > less a consistent style already where e.g. sig-1 without spaces seems to > be preferred. The same for the casts where most places use a single > space. > > Now, I know CodingStyle.rst is on your side at least when it comes to > the first point: > > Use one space around (on each side of) most binary and ternary operators, > such as any of these:: > > = + - < > * / % | & ^ <= >= == != ? : > > but then you'd need to change each place in kernel/signal.c where that > is currently not the case.
Or simply leave this code alone ;)
To be honest I do not like the very idea of enforce-coding-style patches, coding style is very personal and even this trivial (but imho pointless) change can complicate the backporting of some bugfix. I hit this problem quite often.
Oleg.
| |