lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 212/255] drm/dp_mst: Dont return error code when crtc is null
    Date
    From: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>

    commit 88fee1c9007a38c19f2c558dc0ab1ddb4c323dc5 upstream.

    [Why]
    In certain cases the crtc can be NULL and returning -EINVAL causes
    atomic check to fail when it shouln't. This leads to valid
    configurations failing because atomic check fails.

    [How]
    Don't early return if crtc is null

    Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Reviewed-by: Lyude Paul <lyude@redhat.com>
    [added stable cc]
    Signed-off-by: Lyude Paul <lyude@redhat.com>
    Fixes: 8ec046716ca8 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
    Cc: <stable@vger.kernel.org> # v5.6+
    Link: https://patchwork.freedesktop.org/patch/msgid/20200814170140.24917-1-Bhawanpreet.Lakha@amd.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpu/drm/drm_dp_mst_topology.c
    +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
    @@ -4993,8 +4993,8 @@ int drm_dp_mst_add_affected_dsc_crtcs(st

    crtc = conn_state->crtc;

    - if (WARN_ON(!crtc))
    - return -EINVAL;
    + if (!crtc)
    + continue;

    if (!drm_dp_mst_dsc_aux_for_port(pos->port))
    continue;

    \
     
     \ /
      Last update: 2020-09-01 17:56    [W:4.146 / U:0.960 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site