lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] hwmon/pmbus: use simple i2c probe function
On Fri, 7 Aug 2020 08:23:29 -0700, Guenter Roeck <linux@roeck-us.net> wrote:
> On 8/7/20 12:45 AM, Stephen Kitt wrote:
> > pmbus_do_probe doesn't use the id information provided in its second
> > argument, so this can be removed, which then allows using the
> > single-parameter i2c probe function ("probe_new") for probes.
> >
> > This avoids scanning the identifier tables during probes.
> >
> > Drivers which didn't use the id are converted as-is; drivers which did
> > are modified as follows:
> >
> > * if the information in i2c_client is sufficient, that's used instead
> > (client->name);
> > * configured v. probed comparisons are performed by comparing the
> > configured name to the detected name, instead of the ids; this
> > involves strcmp but is still cheaper than comparing all the device
> > names when scanning the tables;
> > * anything else is handled by calling i2c_match_id() with the same
> > level of error-handling (if any) as before.
> >
> > Signed-off-by: Stephen Kitt <steve@sk2.org>
>
> Please also update the documentation.
>
> Documentation/hwmon/pmbus-core.rst: int pmbus_do_probe(struct i2c_client
> *client, const struct i2c_device_id *id, Documentation/hwmon/pmbus.rst:
> return pmbus_do_probe(client, id, &ds1200_info);

Aargh, I usually *start* from the documentation, but I didn’t think to check
in this case.

> Also, please fix the checkpatch issue reported by Wolfram.

Will do, v3 on its way.

Thanks for the reviews!

Regards,

Stephen
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-08-07 19:43    [W:0.051 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site