lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver
On 2020-08-07 08:27, Randy Dunlap wrote:
> On 8/7/20 12:17 AM, Tanmay Shah wrote:
>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>> index ea3c4d094d09..cc1392b29022 100644
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
>> config DRM_MSM_DP
>> bool "Enable DP support in MSM DRM driver"
>> depends on DRM_MSM
>> + default y
>> help
>> Compile in support for DP driver in msm drm driver. DP external
>> display support is enabled through this config option. It can
>
> Hi,
>
> You need a very strong justification to make an optional part of a
> driver
> to be "default y".
>
> so why?
>
Thanks Randy for reviews.
"default y" doesn't belong there. Thanks for pointing that.
It will be fixed in next patch.

> thanks.

\
 
 \ /
  Last update: 2020-08-07 17:55    [W:0.111 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site