lkml.org 
[lkml]   [2020]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class
    On Sat 2020-07-25 20:48:46, Andrew Lunn wrote:
    > > > > +#if 0
    > > > > + /* LED_COLOR_ID_MULTI is not yet merged in Linus' tree */
    > > > > + /* TODO: Support DUAL MODE */
    > > > > + if (color == LED_COLOR_ID_MULTI) {
    > > > > + phydev_warn(phydev, "node %pOF: This driver does not yet support multicolor LEDs\n",
    > > > > + np);
    > > > > + return -ENOTSUPP;
    > > > > + }
    > > > > +#endif
    > > >
    > > > Code getting committed should not be using #if 0. Is the needed code
    > > > in the LED tree? Do we want to consider a stable branch of the LED
    > > > tree which DaveM can pull into net-next? Or do you want to wait until
    > > > the next merge cycle?
    > >
    > > That's why this is RFC. But yes, I would like to have this merged for
    > > 5.9, so maybe we should ask Dave. Is this common? Do we also need to
    > > tell Pavel or how does this work?
    >
    > The Pavel needs to create a stable branch. DaveM then merges that
    > branch into net-next. Your patches can then be merged. When Linus
    > pulls the two branches, led and net-next, git sees the exact same
    > patches twice, and simply drops them from the second pull request.
    >
    > So you need to ask Pavel and DaveM if they are willing to do this.

    Multicolor should be upstream now, so I believe this is no longer
    required?

    > > I also want this code to be generalized somehow so that it can be
    > > reused. The problem is that I want to have support for DUAL mode, which
    > > is Marvell specific, and a DUAL LED needs to be defined in device tree.
    >
    > It sounds like you first need to teach the LED core about dual LEDs
    > and triggers which affect two LEDs..

    Umm. Yes, triggers for controlling both intensity and hue will be
    interesting. Suggestions welcome.

    Best regards,
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-08-07 11:12    [W:2.419 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site