lkml.org 
[lkml]   [2020]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nfc: enforce CAP_NET_RAW for raw sockets When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first.
On Thu, 6 Aug 2020 10:28:08 +0800 Qingyu Li wrote:

Commit message is required. Perhaps shorten the subject and put more
info here.

> Signed-off-by: Qingyu Li <ieatmuttonchuan@gmail.com>
> ---
> net/nfc/rawsock.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c
> index ba5ffd3badd3..c1302b689a98 100644
> --- a/net/nfc/rawsock.c
> +++ b/net/nfc/rawsock.c
> @@ -332,8 +332,11 @@ static int rawsock_create(struct net *net, struct socket *sock,
> if ((sock->type != SOCK_SEQPACKET) && (sock->type != SOCK_RAW))
> return -ESOCKTNOSUPPORT;
>
> - if (sock->type == SOCK_RAW)
> + if (sock->type == SOCK_RAW){
> + if (!capable(CAP_NET_RAW))
> + return -EPERM;
> sock->ops = &rawsock_raw_ops;
> + }

please run checkpatch.pl --strict and fix the issues.

> else
> sock->ops = &rawsock_ops;
>
>
>

\
 
 \ /
  Last update: 2020-08-06 20:33    [W:0.026 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site