lkml.org 
[lkml]   [2020]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: pwm: Do not print error on probe deferral
On Thu, Aug 06, 2020 at 05:55:15PM +0200, Thierry Reding wrote:

> if (IS_ERR(drvdata->enb_gpio)) {
> ret = PTR_ERR(drvdata->enb_gpio);
> - dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);

This will not provide any diagnostics if there's an issue with probe
deferral it'll be hard for people to figure out what's going on. At
most lower the severity to dev_dbg() but don't totally remove the
logging.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-08-06 19:57    [W:0.032 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site