Messages in this thread | | | Subject | Re: [PATCH] blkcg: add plugging support for punt bio | From | Jens Axboe <> | Date | Thu, 6 Aug 2020 09:16:34 -0600 |
| |
On 8/6/20 7:54 AM, Xianting Tian wrote: > Try to merge continuous bio to current task's plug fisrt.
The patch looks fine to me, but I'd really like to see a bit more changelog here. The commit message should explain why the change is made, rather it's a very brief explanation of what it does.
If the bio list is contiguous, then we do the plugging to improve merging at the lower level. You probably ran into a case where you saw sub-optimal merging? And now the performance is better with the patch? How much?
-- Jens Axboe
| |