Messages in this thread | | | Subject | Re: [RFC PATCH 1/3] selftests: Add VRF icmp error route lookup test | From | David Ahern <> | Date | Thu, 6 Aug 2020 11:00:24 -0600 |
| |
On 7/29/20 3:12 PM, Mathieu Desnoyers wrote: > From: Michael Jeanson <mjeanson@efficios.com> > > The objective is to check that the incoming vrf routing table is selected > to send an ICMP error back to the source when the ttl of a packet reaches 1 > while it is forwarded between different vrfs. > > The first test sends a ping with a ttl of 1 from h1 to h2 and parses the > output of the command to check that a ttl expired error is received. > > [This may be flaky, I'm open to suggestions of a more robust approch.] > > The second test runs traceroute from h1 to h2 and parses the output to check > for a hop on r1. > > Signed-off-by: Michael Jeanson <mjeanson@efficios.com> > Cc: David Ahern <dsa@cumulusnetworks.com>
Update the address to dsahern@kernel.org
> Cc: David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org > --- > tools/testing/selftests/net/Makefile | 1 + > .../selftests/net/vrf_icmp_error_route.sh | 461 ++++++++++++++++++ > 2 files changed, 462 insertions(+) > create mode 100755 tools/testing/selftests/net/vrf_icmp_error_route.sh >
Test seems fine to me. you copied icmp_redirect.sh which is fine but please clean up comments and functions not needed for this test.
| |