Messages in this thread | | | From | Gene Chen <> | Date | Thu, 6 Aug 2020 11:30:56 +0800 | Subject | Re: [PATCH 9/9] mfd: mt6360: Merge different sub-devices I2C read/write |
| |
Mark Brown <broonie@kernel.org> 於 2020年8月6日 週四 上午12:10寫道: > > On Wed, Aug 05, 2020 at 12:33:02AM +0800, Gene Chen wrote: > > From: Gene Chen <gene_chen@richtek.com> > > > > Remove unuse register definition. > > Merge different sub-devices I2C read/write functions into one Regmap, > > because PMIC and LDO part need CRC bits for access protection. > > It's not clear why this isn't just done in the device regmap, there's > exactly one user?
because I use one regmap to access 4 I2C devices, I need change the regmap_bus struct to fit I2C read/write with CRC bit Therefore, MFD reviewer suggests I can move the regmap api to regmap folder such as regmap-ac97.c
Is it okay to apply this change?
| |