lkml.org 
[lkml]   [2020]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked
Date


> -----Original Message-----
> From: Sudeep Holla <sudeep.holla@arm.com>
> Sent: Wednesday, August 5, 2020 4:48 PM
> To: Jason Liu <jason.hui.liu@nxp.com>
> Cc: Marc Zyngier <maz@kernel.org>; catalin.marinas@arm.com;
> will@kernel.org; sashal@kernel.org; linux-kernel@vger.kernel.org; Sudeep
> Holla <sudeep.holla@arm.com>; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it
> already masked
>
> On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote:
> > >
> > > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to
> > > mask_irq from drivers or anywhere with irqchip suspended with just
> > > blows up the system.
> >
> > If you look at the chip->irq_mask implementation on different
> > platforms, almost all with directly access the register of the irqchip including
> irqsteer.
> > There are fine due to driver will use the common mask_irq API.
> >
>
> That still doesn't explain how you can prevent system from blowing up if
> chip->irq_mask gets called with irqchip suspended ?

Do you mean driver, the driver will not call chip->irq_mask when irqchip was in suspend.
if it does, it will be big BUG. I believe we don't do that in the driver.

>
> --
> Regards,
> Sudeep

\
 
 \ /
  Last update: 2020-08-06 12:11    [W:0.568 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site