Messages in this thread | | | Date | Thu, 6 Aug 2020 12:56:18 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code |
| |
On Fri, May 29, 2020 at 11:48:53PM +0200, Miguel Ojeda wrote: > Hi Andy, > > On Mon, May 18, 2020 at 9:36 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > hex_to_bin() may be used to convert hexdecimal digit to its binary > > representation. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > Looks fine to me and the logic is simpler for the `esc` increase too. > Thanks for the cleanup! Were you able to test it, by any chance? I > will queue it up for -rc1.
May I ask which version did you have in mind? Now it's merge window for v5.9-rc1 and patch is still not there...
> (Sidenote: it would be nice if `git patch` allowed for a full-to-full > comparison for patches like this since the unified format is harder to > read; I couldn't find the option from a quick look...). > > Cheers, > Miguel
-- With Best Regards, Andy Shevchenko
| |