lkml.org 
[lkml]   [2020]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] openrisc: uaccess: Fix sparse address space warnings
On Tue, Aug 04, 2020 at 01:23:50PM +0900, Stafford Horne wrote:
> The OpenRISC user access functions put_user(), get_user() and
> clear_user() were missing proper sparse annotations. This generated
> warnings like the below.
>
> This patch adds the annotations to fix the warnings.
>
> Example warnings:
>
> net/ipv4/ip_sockglue.c:759:29: warning: incorrect type in argument 1 (different address spaces)
> net/ipv4/ip_sockglue.c:759:29: expected void const volatile [noderef] __user *
> net/ipv4/ip_sockglue.c:759:29: got int const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29: warning: incorrect type in initializer (different address spaces)
> net/ipv4/ip_sockglue.c:764:29: expected unsigned char const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29: got unsigned char [noderef] __user *
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Look good to me.

-- Luc

\
 
 \ /
  Last update: 2020-08-04 22:46    [W:0.112 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site