Messages in this thread | | | Date | Tue, 4 Aug 2020 13:56:50 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled |
| |
On Tue, Aug 04, 2020 at 01:49:51PM +0200, Samuel Thibault wrote: > Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit: > > On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote: > > > Drivers using serialio are already made available in Kconfig only under > > > the ISA condition. > > > > > > This solves warnings in inb/outb macros on platform that do not have > > > support for ISA. > > > > > > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> > > > > > > Index: linux-2.6/drivers/accessibility/speakup/Makefile > > > =================================================================== > > > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile > > > +++ linux-2.6/drivers/accessibility/speakup/Makefile > > > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe > > > obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o > > > > > > obj-$(CONFIG_SPEAKUP) += speakup.o > > > +obj-$(CONFIG_ISA) += serialio.o > > > speakup-y := \ > > > buffers.o \ > > > devsynth.o \ > > > @@ -25,7 +26,6 @@ speakup-y := \ > > > keyhelp.o \ > > > kobjects.o \ > > > selection.o \ > > > - serialio.o \ > > > spk_ttyio.o \ > > > synth.o \ > > > thread.o \ > > > > Oops, no, I get the following build errors with this patch: > > > > ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined! > > Yes, it depends on the first of the queue.
Ah, missed that, ok, let me try this again...
| |