Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v4 05/10] sched/topology: Define and assign sched_domain flag metadata | Date | Tue, 04 Aug 2020 12:12:57 +0100 |
| |
On 04/08/20 12:08, peterz@infradead.org wrote: > On Fri, Jul 31, 2020 at 12:54:57PM +0100, Valentin Schneider wrote: >> +/* >> + * Domain members share CPU capacity (i.e. SMT) >> + * >> + * SHARED_CHILD: Set from the base domain up until spanned CPUs no longer share >> + * CPU capacity. >> + */ >> +SD_FLAG(SD_SHARE_CPUCAPACITY, 6, SDF_SHARED_CHILD) >> + >> +/* >> + * Domain members share CPU package resources (i.e. caches) >> + * >> + * SHARED_CHILD: Set from the base domain up until spanned CPUs no longer share >> + * the same cache(s). >> + */ >> +SD_FLAG(SD_SHARE_PKG_RESOURCES, 7, SDF_SHARED_CHILD) > > We should probably rename these to SD_SHARE_CORE / SD_SHARE_CACHE or > something,
SD_SHARE_CACHE sounds good, given how it's used (LLC stuff).
> but let me first go through this series (and hopefully apply) > before we go make more changes. > > > .. onwards!
Thanks!
| |