Messages in this thread | | | Date | Tue, 4 Aug 2020 10:34:29 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() |
| |
On Sat 2020-08-01 13:46:20, Sergey Senozhatsky wrote: > On (20/07/31 21:08), Andy Shevchenko wrote: > > First of all, there is no compile time check for the SMALL > > to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check > > is hidden in the code. > > > > For better maintenance replace BUILD_BUG_ON() with static_assert() > > for ZEROPAD and move it closer to the definition. While at it, > > introduce check for SMALL. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Just for record, for the entire series:
Reviewed-by: Petr Mladek <pmladek@suse.com>
> The series was applied to for-5.9
There is no need to rebase the git repository. I just want to inform you that the changes look fine to me.
Thanks a lot for the fixes and their handling.
Best Regards, Petr
| |