lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs
From
Date

>>>>>> Detect cases where the clock is assumed to be stopped but the IP is
>>>>>> not in the relevant state, and add a dynamic debug trace.
>>>>>
>>>>> you meant a debug print..and it looks like error print below (also in title).
>>>>
>>>> I don't understand the comment. Is the 'trace' confusing and are you asking
>>>> to e.g. change the commit message to 'add dynamic debug log'?
>>>
>>> Question is what is dynamic about this?
>> dev_dbg() is part of the kernel dynamic debug capability...
>>
>> https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html
>>
>> Not sure what you are asking here?
>
> :-| where is dev_dbg() ?
>
> See [1]

>
> [1]
>
>> + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__);
>
> ^^^^^^^

it's still a log using the "dynamic debug" framework.

Again, what are you asking us to fix?

\
 
 \ /
  Last update: 2020-08-31 17:16    [W:0.108 / U:2.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site