Messages in this thread | | | Date | Fri, 28 Aug 2020 12:53:42 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ |
| |
On 26-08-20, 11:57, Pierre-Louis Bossart wrote: > > > > +#include <linux/device.h> > > > +#include <linux/errno.h> > > > +#include <linux/mod_devicetable.h> > > > > Curious why do you need this header? > > I'll return the question back to you, since you added this header for > regmap-sdw.c: > > 7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include > <linux/mod_devicetable.h>
Looks like it should be removed :)
I could compile it without any issues on few archs I do. let me push the patch on my tree and see if bots are happy, will send the patch
> > so I assumed it was needed here as well. > > > > +MODULE_DESCRIPTION("Regmap SoundWire Module"); > > > > This is same of sdw module, pls make this one a bit different. > > yes, fixed.
-- ~Vinod
| |