lkml.org 
[lkml]   [2020]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()
    From
    Date


    On 27. 08. 20 22:08, Krzysztof Kozlowski wrote:
    > Common pattern of handling deferred probe can be simplified with
    > dev_err_probe(). Less code and also it prints the error value.
    >
    > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    > ---
    > drivers/gpio/gpio-zynq.c | 8 +++-----
    > 1 file changed, 3 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
    > index 53d1387592fd..0b5a17ab996f 100644
    > --- a/drivers/gpio/gpio-zynq.c
    > +++ b/drivers/gpio/gpio-zynq.c
    > @@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
    >
    > /* Retrieve GPIO clock */
    > gpio->clk = devm_clk_get(&pdev->dev, NULL);
    > - if (IS_ERR(gpio->clk)) {
    > - if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)
    > - dev_err(&pdev->dev, "input clock not found.\n");
    > - return PTR_ERR(gpio->clk);
    > - }
    > + if (IS_ERR(gpio->clk))
    > + return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
    > +
    > ret = clk_prepare_enable(gpio->clk);
    > if (ret) {
    > dev_err(&pdev->dev, "Unable to enable clock.\n");
    >

    Reviewed-by: Michal Simek <michal.simek@xilinx.com>

    Thanks,
    Michal

    \
     
     \ /
      Last update: 2020-08-28 07:21    [W:4.730 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site