Messages in this thread Patch in this message | | | From | Chunguang Xu <> | Subject | [PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code | Date | Thu, 27 Aug 2020 18:14:24 +0800 |
| |
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis.
Signed-off-by: Chunguang Xu <brookxu@tencent.com> --- drivers/block/sx8.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index 4478eb7..d9adcf3 100644 --- a/drivers/block/sx8.c +++ b/drivers/block/sx8.c @@ -93,11 +93,7 @@ #ifdef CARM_NDEBUG #define assert(expr) #else -#define assert(expr) \ - if(unlikely(!(expr))) { \ - printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n", \ - #expr, __FILE__, __func__, __LINE__); \ - } +#define assert(expr) ASSERT_WARN(expr) #endif /* defines only for the constants which don't work well as enums */ -- 1.8.3.1
| |