| From | Andy Shevchenko <> | Date | Thu, 27 Aug 2020 12:06:46 +0300 | Subject | Re: [PATCH 06/24] Input: pwm-vibra - Simplify with dev_err_probe() |
| |
On Wed, Aug 26, 2020 at 9:18 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value.
> err = PTR_ERR_OR_ZERO(vibrator->vcc); > + if (err) > + return dev_err_probe(&pdev->dev, err, "Failed to request regulator\n");
Same comment, no need to have additional PTR_ERR_OZR_ZERO().
-- With Best Regards, Andy Shevchenko
|