lkml.org 
[lkml]   [2020]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] perf expr: Force encapsulation on expr_id_data
From
Date


On 8/26/20 9:27 PM, Jiri Olsa wrote:
> On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote:
>> This patch resolves some undefined behavior where variables in
>> expr_id_data were accessed (for debugging) without being defined. To
>> better enforce the tagged union behavior, the struct is moved into
>> expr.c and accessors provided. Tag values (kinds) are explicitly
>> identified.

Reviewed-By: Kajol Jain<kjain@linux.ibm.com>

Thanks,
Kajol Jain
>>
>> Signed-off-by: Ian Rogers <irogers@google.com>
>
> great, thanks for doing this
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> jirka
>

\
 
 \ /
  Last update: 2020-08-27 09:02    [W:0.055 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site