Messages in this thread | | | Subject | Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data | From | kajoljain <> | Date | Thu, 27 Aug 2020 12:30:12 +0530 |
| |
On 8/26/20 9:27 PM, Jiri Olsa wrote: > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: >> This patch resolves some undefined behavior where variables in >> expr_id_data were accessed (for debugging) without being defined. To >> better enforce the tagged union behavior, the struct is moved into >> expr.c and accessors provided. Tag values (kinds) are explicitly >> identified.
Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
Thanks, Kajol Jain >> >> Signed-off-by: Ian Rogers <irogers@google.com> > > great, thanks for doing this > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > jirka >
| |