Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] ath10k: Add interrupt summary based CE processing | Date | Wed, 26 Aug 2020 17:43:42 +0300 |
| |
(Guys, PLEASE edit your quotes. These long emails my use of patchwork horrible.)
"Rakesh Pillai" <pillair@codeaurora.org> writes:
>> -----Original Message----- >> From: Peter Oh <peter.oh@eero.com> >> Sent: Tuesday, July 21, 2020 7:03 AM >> To: Kalle Valo <kvalo@codeaurora.org> >> Cc: Brian Norris <briannorris@chromium.org>; Doug Anderson >> <dianders@chromium.org>; linux-wireless <linux- >> wireless@vger.kernel.org>; Rakesh Pillai <pillair@codeaurora.org>; ath10k >> <ath10k@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org> >> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing >> >> I'll take my word back. >> It's not this patch problem, but by others. >> I have 2 extra patches before the 3 patches so my system looks like >> >> backports from ath.git 5.6-rc1 + linux kernel 4.4 (similar to OpenWrt) >> On top of the working system, I cherry-picked these 5. >> >> #1. >> ath10k: Avoid override CE5 configuration for QCA99X0 chipsets >> ath.git commit 521fc37be3d879561ca5ab42d64719cf94116af0 >> #2. >> ath10k: Fix NULL pointer dereference in AHB device probe >> wireless-drivers.git commit 1cfd3426ef989b83fa6176490a38777057e57f6c >> #3. >> ath10k: Add interrupt summary based CE processing >> https://patchwork.kernel.org/patch/11628299/ > > This patch is applicable only for snoc target WCN3990, since there is > a check for per_ce_irq. For PCI targets, per_ce_irq is false, and > hence follows a different path.
This information should be in the commit log. But I have a patch in the pending branch which removes per_ce_irq:
[v2,2/2] ath10k: Get rid of "per_ce_irq" hw param
https://patchwork.kernel.org/patch/11654621/
So how will multilple hardware support work then?
In theory I like the patch but there's no information in the patch if this works or breaks other hardware, especially QCA9884 or QCA6174 PCI devices. I really need some kind of assurance that this works with all ath10k devices, not just WCN3990 which you are working on.
I have written about this in the wiki:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#hardware_families
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |