lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/30] wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'hw' not described in 'zd_mac_tx_status'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'skb' not described in 'zd_mac_tx_status'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'tx_status' not described in 'zd_mac_tx_status'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Excess function parameter 'flags' description in 'zd_mac_tx_status'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Function parameter or member 'urb' not described in 'zd_mac_tx_failed'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Excess function parameter 'dev' description in 'zd_mac_tx_failed'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Function parameter or member 'hw' not described in 'zd_op_tx'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Excess function parameter 'dev' description in 'zd_op_tx'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Function parameter or member 'hw' not described in 'filter_ack'
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Excess function parameter 'dev' description in 'filter_ack'

    Cc: Daniel Drake <dsd@gentoo.org>
    Cc: Ulrich Kunitz <kune@deine-taler.de>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Michael Wu <flamingice@sourmilk.net>
    Cc: "Luis R. Rodriguez" <mcgrof@winlab.rutgers.edu>
    Cc: linux-wireless@vger.kernel.org
    Cc: netdev@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 15 +++++++--------
    1 file changed, 7 insertions(+), 8 deletions(-)

    diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
    index a9999d10ae81f..3ef8533205f91 100644
    --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
    +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
    @@ -416,11 +416,10 @@ int zd_restore_settings(struct zd_mac *mac)

    /**
    * zd_mac_tx_status - reports tx status of a packet if required
    - * @hw - a &struct ieee80211_hw pointer
    - * @skb - a sk-buffer
    - * @flags: extra flags to set in the TX status info
    + * @hw: a &struct ieee80211_hw pointer
    + * @skb: a sk-buffer
    * @ackssi: ACK signal strength
    - * @success - True for successful transmission of the frame
    + * @tx_status: success and/or retry
    *
    * This information calls ieee80211_tx_status_irqsafe() if required by the
    * control information. It copies the control information into the status
    @@ -477,7 +476,7 @@ static void zd_mac_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb,

    /**
    * zd_mac_tx_failed - callback for failed frames
    - * @dev: the mac80211 wireless device
    + * @urb: pointer to the urb structure
    *
    * This function is called if a frame couldn't be successfully
    * transferred. The first frame from the tx queue, will be selected and
    @@ -913,9 +912,9 @@ static int fill_ctrlset(struct zd_mac *mac,
    /**
    * zd_op_tx - transmits a network frame to the device
    *
    - * @dev: mac80211 hardware device
    - * @skb: socket buffer
    + * @hw: a &struct ieee80211_hw pointer
    * @control: the control structure
    + * @skb: socket buffer
    *
    * This function transmit an IEEE 802.11 network frame to the device. The
    * control block of the skbuff will be initialized. If necessary the incoming
    @@ -946,7 +945,7 @@ static void zd_op_tx(struct ieee80211_hw *hw,

    /**
    * filter_ack - filters incoming packets for acknowledgements
    - * @dev: the mac80211 device
    + * @hw: a &struct ieee80211_hw pointer
    * @rx_hdr: received header
    * @stats: the status for the received packet
    *
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-26 11:39    [W:4.789 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site