Messages in this thread | | | Date | Wed, 26 Aug 2020 09:00:03 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v1 4/9] extcon: extcon-ptn5150: Switch to BIT() for cable detach macro |
| |
On Tue, Aug 18, 2020 at 02:57:22PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Switch to BIT() macro for the cable detach.
Squash it.
Best regards, Krzysztof
> > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > --- > drivers/extcon/extcon-ptn5150.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > index fab862d9aad8..50fff148b772 100644 > --- a/drivers/extcon/extcon-ptn5150.c > +++ b/drivers/extcon/extcon-ptn5150.c > @@ -45,10 +45,7 @@ enum ptn5150_reg { > #define PTN5150_REG_CC_VBUS_DETECTION BIT(7) > > #define PTN5150_REG_INT_CABLE_ATTACH_MASK BIT(0) > - > -#define PTN5150_REG_INT_CABLE_DETACH_SHIFT 1 > -#define PTN5150_REG_INT_CABLE_DETACH_MASK \ > - (0x1 << PTN5150_REG_CC_CABLE_DETACH_SHIFT) > +#define PTN5150_REG_INT_CABLE_DETACH_MASK BIT(1) > > struct ptn5150_info { > struct device *dev; > -- > 2.11.0 >
| |