Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 00/13] lib/generic-radix-tree: genradix bug fix and optimisations. | Date | Tue, 25 Aug 2020 16:00:35 +0000 |
| |
From: 'Marcelo Ricardo Leitner' > Sent: 25 August 2020 16:41 > > On Tue, Aug 25, 2020 at 02:52:34PM +0000, David Laight wrote: > > The genradix code is used by SCTP for accessing per-stream data. > > This means there are quite a lot of lookups but the code wasn't > > really optimised at all. > > My test box is down for the moment and will bring it on later today or > tomorrow, so I can't test it yet. What should we expect as performance > gains here?
Not sure, probably not much, but it ought to show up :-) There'll be bigger gains on a cpu that has software ilog2().
I've only checked SCTP still works. I've requested 32k streams on a listener - to force a level-2 tree. I've also done at least one check with a massive pad in the sctp stream structure.
I ought to check one of my M3UA or M2PA 'double-reflect' loopback tests.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |